{"id":349707,"date":"2023-07-04T09:00:46","date_gmt":"2023-07-04T09:00:46","guid":{"rendered":"http:\/\/savepearlharbor.com\/?p=349707"},"modified":"-0001-11-30T00:00:00","modified_gmt":"-0001-11-29T21:00:00","slug":"","status":"publish","type":"post","link":"https:\/\/savepearlharbor.com\/?p=349707","title":{"rendered":"\u0418\u0437\u0443\u0447\u0430\u0435\u043c \u043f\u043e\u0434\u043e\u0437\u0440\u0438\u0442\u0435\u043b\u044c\u043d\u044b\u0435 \u043c\u0435\u0441\u0442\u0430 \u0432 \u043a\u043e\u0434\u0435 AWS SDK \u0434\u043b\u044f .NET<\/span>"},"content":{"rendered":"
<\/div>\n
\n
\n
\n
\n

\"1057_AWS_SDK_NET_ru\/image1.png\"<\/p>\n

<\/p>\n

\u0421\u0435\u0433\u043e\u0434\u043d\u044f \u043f\u043e\u0434 \u043d\u0430\u0448\u0438\u043c \u0441\u043a\u0430\u043b\u044c\u043f\u0435\u043b\u0435\u043c \u043e\u043a\u0430\u0437\u0430\u043b\u0441\u044f \u043f\u0440\u043e\u0435\u043a\u0442 AWS SDK \u0434\u043b\u044f .NET. \u041c\u044b \u043f\u043e\u0441\u043c\u043e\u0442\u0440\u0438\u043c \u043d\u0430 \u043f\u043e\u0434\u043e\u0437\u0440\u0438\u0442\u0435\u043b\u044c\u043d\u044b\u0435 \u043c\u0435\u0441\u0442\u0430 \u0438\u0437 \u0438\u0441\u0445\u043e\u0434\u043d\u043e\u0433\u043e \u043a\u043e\u0434\u0430, \u0440\u0430\u0437\u0431\u0435\u0440\u0451\u043c\u0441\u044f, \u0447\u0442\u043e \u0432 \u043d\u0438\u0445 \u043f\u0440\u043e\u0438\u0441\u0445\u043e\u0434\u0438\u0442, \u0438 \u043f\u043e\u043f\u0440\u043e\u0431\u0443\u0435\u043c \u0432\u043e\u0441\u043f\u0440\u043e\u0438\u0437\u0432\u0435\u0441\u0442\u0438 \u043d\u0435\u043a\u043e\u0442\u043e\u0440\u044b\u0435 \u043f\u0440\u043e\u0431\u043b\u0435\u043c\u044b. \u0417\u0430\u0432\u0430\u0440\u0438\u0432\u0430\u0439\u0442\u0435 \u043a\u043e\u0444\u0435 \u0438 \u0443\u0441\u0442\u0440\u0430\u0438\u0432\u0430\u0439\u0442\u0435\u0441\u044c \u043f\u043e\u0443\u0434\u043e\u0431\u043d\u0435\u0435.<\/p>\n

<\/a> <\/p>\n

\u041d\u0435\u043c\u043d\u043e\u0433\u043e \u0434\u0435\u0442\u0430\u043b\u0435\u0439 \u043e\u0431 \u0430\u043d\u0430\u043b\u0438\u0437\u0435<\/h2>\n

<\/p>\n

\u0427\u0442\u043e \u0437\u0430 \u043f\u0440\u043e\u0435\u043a\u0442?<\/strong><\/p>\n

<\/p>\n

AWS.SDK \u0434\u043b\u044f .NET \u2014 \u043f\u0440\u043e\u0435\u043a\u0442, \u043a\u043e\u0442\u043e\u0440\u044b\u0439 \u043f\u043e\u043c\u043e\u0433\u0430\u0435\u0442 \u0440\u0430\u0431\u043e\u0442\u0430\u0442\u044c \u0441 Amazon Web Services, Amazon S3, Amazon DynamoDB \u0438 \u0442. \u043f. \u0418\u0441\u0445\u043e\u0434\u043d\u0438\u043a\u0438 \u0432\u0437\u044f\u043b \u0441\u043e \u0441\u0442\u0440\u0430\u043d\u0438\u0446\u044b \u043f\u0440\u043e\u0435\u043a\u0442\u0430 \u043d\u0430 GitHub<\/a>. \u0415\u0441\u043b\u0438 \u043d\u0443\u0436\u043d\u0430 \u0442\u043e\u0447\u043d\u0430\u044f \u0432\u0435\u0440\u0441\u0438\u044f, \u0432\u043e\u0442 SHA \u043a\u043e\u043c\u043c\u0438\u0442\u0430: 93a94821dc8ff7a0073b74def6549728da3b51c7.<\/p>\n

<\/p>\n

\u0427\u0435\u043c \u043f\u0440\u043e\u0432\u0435\u0440\u044f\u043b\u0438?<\/strong><\/p>\n

<\/p>\n

\u041a\u043e\u0434 \u043f\u0440\u043e\u0432\u0435\u0440\u044f\u043b \u0430\u043d\u0430\u043b\u0438\u0437\u0430\u0442\u043e\u0440\u043e\u043c PVS-Studio<\/a> \u0447\u0435\u0440\u0435\u0437 \u043f\u043b\u0430\u0433\u0438\u043d \u0434\u043b\u044f Visual Studio. <\/p>\n

<\/p>\n

\u0427\u0442\u043e-\u0442\u043e \u0435\u0449\u0451?<\/strong><\/p>\n

<\/p>\n

\u041d\u0435\u043a\u043e\u0442\u043e\u0440\u044b\u0435 \u043f\u0440\u0435\u0434\u0443\u043f\u0440\u0435\u0436\u0434\u0435\u043d\u0438\u044f \u043c\u043e\u0433\u0443\u0442 \u043f\u043e\u043a\u0430\u0437\u0430\u0442\u044c\u0441\u044f \u0432\u0430\u043c \u0437\u043d\u0430\u043a\u043e\u043c\u044b\u043c\u0438 \u2014 \u043c\u0435\u0441\u0442\u0430\u043c\u0438 \u043a\u043e\u0434 \u043d\u0435 \u043f\u043e\u043c\u0435\u043d\u044f\u043b\u0441\u044f \u0441\u043e \u0432\u0440\u0435\u043c\u0435\u043d\u0438 \u043f\u0440\u043e\u0448\u043b\u043e\u0439 \u043f\u0440\u043e\u0432\u0435\u0440\u043a\u0438<\/a>. \u0415\u0441\u043b\u0438 \u043f\u0440\u0435\u0434\u0443\u043f\u0440\u0435\u0436\u0434\u0435\u043d\u0438\u044f \u043a\u0430\u0437\u0430\u043b\u0438\u0441\u044c \u043c\u043d\u0435 \u0434\u043e\u0441\u0442\u0430\u0442\u043e\u0447\u043d\u043e \u0438\u043d\u0442\u0435\u0440\u0435\u0441\u043d\u044b\u043c\u0438, \u044f \u0434\u0443\u0431\u043b\u0438\u0440\u043e\u0432\u0430\u043b \u0438\u0445 \u0432 \u044d\u0442\u0443 \u0441\u0442\u0430\u0442\u044c\u044e.<\/p>\n

<\/p>\n

\u041d\u043e \u0445\u0432\u0430\u0442\u0438\u0442 \u043e \u0434\u0435\u0442\u0430\u043b\u044f\u0445 \u043f\u0440\u043e\u0432\u0435\u0440\u043a\u0438, \u043f\u0435\u0440\u0435\u0445\u043e\u0434\u0438\u043c \u043d\u0435\u043f\u043e\u0441\u0440\u0435\u0434\u0441\u0442\u0432\u0435\u043d\u043d\u043e \u043a \u0440\u0430\u0437\u0431\u043e\u0440\u0443 \u043f\u043e\u0434\u043e\u0437\u0440\u0438\u0442\u0435\u043b\u044c\u043d\u044b\u0445 \u043c\u0435\u0441\u0442 \u0432 \u043a\u043e\u0434\u0435.<\/p>\n

<\/p>\n

\u0420\u0430\u0437\u0431\u043e\u0440 \u043f\u043e\u0434\u043e\u0437\u0440\u0438\u0442\u0435\u043b\u044c\u043d\u044b\u0445 \u0444\u0440\u0430\u0433\u043c\u0435\u043d\u0442\u043e\u0432 \u043a\u043e\u0434\u0430<\/h2>\n

<\/p>\n

Issue #1<\/strong><\/p>\n

<\/p>\n

public static object GetAttr(object value, string path) {   if (string.IsNullOrEmpty(path)) throw new ArgumentNullException(\"path\");    var parts = path.Split('.');   var propertyValue = value;    for (int i = 0; i < parts.Length; i++)   {     var part = parts[i];      \/\/ indexer is always at the end of path e.g. \"Part1.Part2[3]\"     if (i == parts.Length - 1)     {       ....       \/\/ indexer detected       if (indexerStart >= 0)       {         ....         if (!(propertyValue is IList))            throw              new ArgumentException(\"Object addressing by pathing segment '{part}'                                    with indexer must be IList\");         ....       }     }     if (!(propertyValue is IPropertyBag))       throw         new ArgumentException(\"Object addressing by pathing segment '{part}'                               must be IPropertyBag\");    ....   }   .... }<\/code><\/pre>\n
  <\/p>\n
\u0421\u0441\u044b\u043b\u043a\u0438 \u043d\u0430 GitHub: #1<\/a>, #2<\/a>.<\/p>\n
  <\/p>\n
                         \u041f\u0440\u0435\u0434\u0443\u043f\u0440\u0435\u0436\u0434\u0435\u043d\u0438\u0435 PVS-Studio \u2014 V3138<\/b>                         <\/p>\n
\n
String literal contains potential interpolated expression. Consider inspecting: part. Fn.cs 82<\/p>\n
  <\/p>\n
String literal contains potential interpolated expression. Consider inspecting: part. Fn.cs 93<\/p>\n<\/div><\/div>\n
  <\/p>\n
\u041f\u043e\u0445\u043e\u0436\u0435, \u0440\u0430\u0437\u0440\u0430\u0431\u043e\u0442\u0447\u0438\u043a \u0437\u0430\u0431\u044b\u043b \u0438\u043d\u0442\u0435\u0440\u043f\u043e\u043b\u0438\u0440\u043e\u0432\u0430\u0442\u044c \u0441\u043e\u043e\u0431\u0449\u0435\u043d\u0438\u044f \u0438\u0441\u043a\u043b\u044e\u0447\u0435\u043d\u0438\u0439. \u0418\u0437-\u0437\u0430 \u044d\u0442\u043e\u0433\u043e \u0432\u043c\u0435\u0441\u0442\u043e \u0444\u0430\u043a\u0442\u0438\u0447\u0435\u0441\u043a\u043e\u0433\u043e \u0437\u043d\u0430\u0447\u0435\u043d\u0438\u044f \u043f\u0435\u0440\u0435\u043c\u0435\u043d\u043d\u043e\u0439 part<\/em> \u0431\u0443\u0434\u0435\u0442 \u0438\u0441\u043f\u043e\u043b\u044c\u0437\u043e\u0432\u0430\u043d \u0441\u0442\u0440\u043e\u043a\u043e\u0432\u044b\u0439 \u043b\u0438\u0442\u0435\u0440\u0430\u043b {part}<\/em>.<\/p>\n
  <\/p>\n
Issue #2<\/strong><\/p>\n
  <\/p>\n
private CredentialsRefreshState Authenticate(ICredentials userCredential) {   ....   ICoreAmazonSTS coreSTSClient = null;   try   {     ....      coreSTSClient =         ServiceClientHelpers.CreateServiceFromAssembly<ICoreAmazonSTS>(....);   }   catch (Exception e)   {     ....   }    var samlCoreSTSClient #if NETSTANDARD     = coreSTSClient as ICoreAmazonSTS_SAML;   if (coreSTSClient == null)   {     throw new NotImplementedException(       \"The currently loaded version of AWSSDK.SecurityToken         doesn't support SAML authentication.\");   } #else     = coreSTSClient; #endif    try   {     var credentials = samlCoreSTSClient.CredentialsFromSAMLAuthentication(....);   }   catch (Exception e)   {     var wrappedException =        new AmazonClientException(\"Credential generation from                                   SAML authentication failed.\",                                  e);      var logger = Logger.GetLogger(typeof(FederatedAWSCredentials));     logger.Error(wrappedException, wrappedException.Message);      throw wrappedException;   }   .... }<\/code><\/pre>\n
  <\/p>\n
\u0421\u0441\u044b\u043b\u043a\u0430 \u043d\u0430 GitHub<\/a>. <\/p>\n
  <\/p>\n
                         \u041f\u0440\u0435\u0434\u0443\u043f\u0440\u0435\u0436\u0434\u0435\u043d\u0438\u0435 PVS-Studio \u2014 V3019<\/b>                         <\/p>\n
\n
Possibly an incorrect variable is compared to null after type conversion using ‘as’ keyword. Check variables ‘coreSTSClient’, ‘samlCoreSTSClient’. FederatedAWSCredentials.cs 219<\/p>\n<\/div><\/div>\n
  <\/p>\n
\u0411\u043e\u043b\u044c\u0448\u043e\u0439 \u0444\u0440\u0430\u0433\u043c\u0435\u043d\u0442 \u043a\u043e\u0434\u0430 \u043d\u0443\u0436\u0435\u043d \u0434\u043b\u044f \u043b\u0443\u0447\u0448\u0435\u0433\u043e \u043f\u043e\u043d\u0438\u043c\u0430\u043d\u0438\u044f \u043a\u043e\u043d\u0442\u0435\u043a\u0441\u0442\u0430. \u0421\u0430\u043c\u0430 \u043e\u0448\u0438\u0431\u043a\u0430 \u0441\u043f\u0440\u044f\u0442\u0430\u043b\u0430\u0441\u044c \u0437\u0434\u0435\u0441\u044c:<\/p>\n
  <\/p>\n
var samlCoreSTSClient #if NETSTANDARD   = coreSTSClient as ICoreAmazonSTS_SAML; if (coreSTSClient == null) {   throw new NotImplementedException(     \"The currently loaded version of AWSSDK.SecurityToken       doesn't support SAML authentication.\"); }<\/code><\/pre>\n
  <\/p>\n
\u041f\u043e\u0445\u043e\u0436\u0435, \u0432 \u0443\u0441\u043b\u043e\u0432\u0438\u0438 \u043e\u043f\u0435\u0440\u0430\u0442\u043e\u0440\u0430 if<\/em> \u043d\u0430 null<\/em> \u043f\u0440\u043e\u0432\u0435\u0440\u044f\u0435\u0442\u0441\u044f \u0437\u043d\u0430\u0447\u0435\u043d\u0438\u0435 \u043d\u0435 \u0442\u043e\u0439 \u043f\u0435\u0440\u0435\u043c\u0435\u043d\u043d\u043e\u0439 \u2014 \u043d\u0443\u0436\u043d\u043e \u0431\u044b\u043b\u043e \u043f\u0440\u043e\u0432\u0435\u0440\u044f\u0442\u044c samlCoreSTSClient<\/em>. <\/p>\n
  <\/p>\n
\u041e\u0431\u0440\u0430\u0442\u0438\u0442\u0435 \u0432\u043d\u0438\u043c\u0430\u043d\u0438\u0435 \u043d\u0430 \u0441\u043b\u0435\u0434\u0443\u044e\u0449\u0438\u0435 \u044d\u043b\u0435\u043c\u0435\u043d\u0442\u044b:<\/p>\n
  <\/p>\n